search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Implement datetime64 as the time dtype #70

Closed lkilcher closed 2 years ago

lkilcher commented 2 years ago

@jmcvey3- I'm definitely interested in you reviewing this. I think this is a major improvement because now we're using real time objects!

Note that one of the big stumbling blocks I think you ran into was fixed in a25008e. Take a look at the details of datetime.fromtimestamp, datetime.utcfromtimestamp, and datetime.timestamp. The fine print there is important! What a mess!

Hurrah!

lkilcher commented 2 years ago

Also, I need you to help me fix all these build errors.

lkilcher commented 2 years ago

@jmcvey3 can we add a windows build (Python 3.9 probably) to the set of tests?

lkilcher commented 2 years ago

Also, should we drop Py3.7 and add Py3.10?