search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Read error cleanup #75

Closed lkilcher closed 2 years ago

lkilcher commented 2 years ago

@jmcvey3 -

I decided to tackle #72 after all.

All of the test files work for the definitions I've specified in the dolfyn.io.base._get_filetype. I think this is a much more robust method of detecting file-type, and if something falls outside these definitions I think the error messages are pretty clear.

Sorry to duplicate/overule your effort in #74 . Let me know what you think?

jmcvey3 commented 2 years ago

@lkilcher Simple and effective, I like it. Also super good call on the git-lfs pointer - I have definitely hit that error before.