search

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).
BSD 3-Clause "New" or "Revised" License
42 stars 25 forks source link

Missing timestamps #77

Open lkilcher opened 2 years ago

lkilcher commented 2 years ago

While working on #76 I realized that I can't put np.datetime64('NaT') into the ds.time. However, this causes problems because sometimes timestamps really are missing. We need to figure out a consistent way to address this issue. It shouldn't be too bad because we should be able to interpolate or extrapolate pretty easily (the sample rate is known after all), but I do think we should issue a warning whenever this happens, and also probably have a flag somewhere that indicates where the bad timestamps were. Maybe a boolean array bad_time variable in the dataset?

jmcvey3 commented 2 years ago

Interpolation done in pull requests #77 and #103. Not currently a bad flag, but missing timestamps will have all "nan" recorded in all data variables