Closed jmcvey3 closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
dolfyn/io/nortek2_lib.py | 28 | 30 | 93.33% | ||
<!-- | Total: | 63 | 65 | 96.92% | --> |
Totals | |
---|---|
Change from base Build 2017114758: | 0.06% |
Covered Lines: | 4613 |
Relevant Lines: | 5087 |
This looks good to me.
Changed some status attributes to variables because it appears they can change with time. Removed 'status0' and 'alt_status', but left in the 'status' variable because it's an easy way to check if a ping is missing as it will never otherwise = 0.
temp_mag
variable is an uncalibrated thermistor, per Nortek integration guide, so it's been droppedstatus
,status0
, andalt_status
and saved as variables or attributesxmit_energy
isn't necessarily constant and has been added back as a data variable rather than an attributequaternion
toquaternions
Setting as pull request to triple check everything before merging into main