ADCP clean surface bugfix - Githubissues

lkilcher / dolfyn

A library for oceanographic doppler instruments such as Acoustic Doppler Profilers (ADPs, ADCPs) and Acoustic Doppler Velocimeters (ADVs).

BSD 3-Clause "New" or "Revised" License

41 stars 25 forks source link

ADCP clean surface bugfix #99

Closed jmcvey3 closed 2 years ago

jmcvey3 commented 2 years ago

[x] Need to add test

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2208606626

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

10 of 13 (76.92%) changed or added relevant lines in 2 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 90.723%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
dolfyn/adp/clean.py	5	6	83.33%
dolfyn/tests/test_clean.py	5	7	71.43%
<!--	Total:	10	13	76.92%	-->

Files with Coverage Reduction	New Missed Lines	%
dolfyn/tests/test_clean.py	5	80.82%
<!--	Total:	5		-->

Totals
Change from base Build 2204964271:	0.04%
Covered Lines:	4645
Relevant Lines:	5120

💛 - Coveralls