search

lkldev / pe

0 stars 0 forks source link

Sequence diagram not following colour scheme #17

Open lkldev opened 2 years ago

lkldev commented 2 years ago

The sequence diagram does not follow the colour scheme used by other sequence diagrams

image.png

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Varying sequence diagrams

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Bugs

There are different formats of sequence diagram found in the DG. The inconsistency would affect reader as there are drastic difference between the two formats

Screenshots

image.png

image.png

[original: nus-cs2103-AY2122S2/pe-interim#2236] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We don't feel that this is an issue, as all the diagrams are unrelated (for separate commands).

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Different bug as this is more towards the colour used by the sequence diagrams, since they have distinct colouring for the different components (red for model, blue for logic).

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I feel that this is still a bug as since the colour represents a component, it should be consistent throughout even if the diagrams are generated by different programs, i.e. logic uses blue boxes, model uses red boxes. Some diagrams have no colour (as shown above) and some of them have different colours, as shown below:

image.png