search

lkldev / pe

0 stars 0 forks source link

Incorrect Case Sensitivity for packages #2

Open lkldev opened 2 years ago

lkldev commented 2 years ago

Steps to reproduce

run addp i/basic package d/

Expected

Package not created as basic package exist (same name)

Actual

Package was created

Screenshots

image.png

Since package name are the unique identifier, it seems like package name should be case insensitive. Also, for a fast typist, it will be easier not to consider the case sensitivity here.

nus-se-script commented 2 years ago

Team's Response

We think that there are some cases where the user may want case sensitive packages as abbreviations/acronyms may make a difference. As such, we chose that the packages should be case sensitive.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Whether the user wants abbreviations/acronyms, I believe package names should still be case insensitive. For instance, if the user wants to add a package AIA, it does not make sense to have two package names AIA and aia, which may confuse the user and they may end up giving the wrong package to the client.