Codecov Report

Merging #111 (8a86dcc) into master (089cf31) will decrease coverage by 1.77%. The diff coverage is 83.65%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   99.26%   97.49%   -1.78%     
==========================================
  Files          11       11              
  Lines         816      917     +101     
==========================================
+ Hits          810      894      +84     
- Misses          6       23      +17

Impacted Files	Coverage Δ
tinnsleep/visualization.py	`90.17% <72.58%> (-9.83%)`	:arrow_down:
tinnsleep/data.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 089cf31...6b72505. Read the comment docs.

lkorczowski commented 3 years ago

@RobinGuillard Unfortunately, it seems that the current NB don't have the modifications made during the PR #101 I supposed that the new NB have been overwritten at some point so we lost a bit.

Tomorrow, I'll take back the NB at the state https://github.com/lkorczowski/Tinnitus-n-Sleep/blob/46c1dc52eea88b0b99243d1e7237dd885dcf8058/notebooks/Middle_ear_Inter_subject_analysis.ipynb and do the modifications again.

lkorczowski commented 3 years ago

@RobinGuillard note that the difference between NB, ie

# NB Bruxism
var[59]="control" #1PA31
var[61]="control" #1CB23
var[70]="control" #3CL02

# NB MEMA
var[70] = "control" #3CL02
var[71] = "control" #3TS03
var[61] = "control" #1CB23
#var[65] = "control" #3BS04
var[67] = "control" #3KB06
var[59] = "control" #1PA31
#var[40] = "control" #1UC22

is not a good pratice. Please update data_info instead ^^

lkorczowski commented 3 years ago

Review NB in reviewNB https://app.reviewnb.com/lkorczowski/Tinnitus-n-Sleep/pull/111/

lkorczowski / Tinnitus-n-Sleep

Etiology #111

Codecov Report