lkorczowski commented 4 years ago

From #27 , valide is_good_epoch and present a pipeline with impedance check in NB

[ ] visualize is_good_epoch results
[ ] build voting pipeline using both is_good and impedance check
[ ] validate in NB

codecov[bot] commented 4 years ago

Codecov Report

Merging #32 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          518       520    +2     
=========================================
+ Hits           518       520    +2

Impacted Files	Coverage Δ
tinnsleep/data.py	`100.00% <ø> (ø)`
tinnsleep/signal.py	`100.00% <ø> (ø)`
tinnsleep/check_impedance.py	`100.00% <100.00%> (ø)`
tinnsleep/visualization.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 178c1ed...0b58342. Read the comment docs.

RobinGuillard commented 4 years ago

Approved until now, not so much changes since last time!

lkorczowski commented 4 years ago

Approved until now, not so much changes since last time!

as mentioned, it is the draft, the NB modifications hasn't been released yet. Also, as you can see, checklist is still blank ^^

lkorczowski / Tinnitus-n-Sleep

Bad Electrode Detection #32

Codecov Report