lkorczowski / Tinnitus-n-Sleep

Detecting events in sleeping tinnitus patients

MIT License

1 stars 0 forks source link

Middle Ear Activity Report #50

Closed lkorczowski closed 4 years ago

lkorczowski commented 4 years ago

[x] inter-subject loop for MEMA
[x] add MEMA-specific parameters in episodes
[x] validate with pytest (@RobinGuillard could you help ?)
[x] massive pytest addition to create_report and scoring because results wasn't reliable when checking
[x] make it fully works in the Middle_ear_inter_subject NB
[x] closes #58

codecov[bot] commented 4 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          598       598           
=========================================
  Hits           598       598

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18fbfaa...18fbfaa. Read the comment docs.

lkorczowski commented 4 years ago

@RobinGuillard I need you help in the test_scoring

https://github.com/lkorczowski/Tinnitus-n-Sleep/blob/562d335617d0f47c49c11104a7d6c5bab1db9d09/tests/test_scoring.py#L100-L104

I don't understand why npt.assert_equal(report["Total burst duration"], 15) should actual be valid. 15 is the length of the vector but not all are actual bursts (e.g. FALSE at the begginning)

Also, I need your help to do the pytest for the MEMA report, https://github.com/lkorczowski/Tinnitus-n-Sleep/blob/562d335617d0f47c49c11104a7d6c5bab1db9d09/tests/test_scoring.py#L107-L123

RobinGuillard commented 4 years ago

@RobinGuillard I need you help in the test_scoring

https://github.com/lkorczowski/Tinnitus-n-Sleep/blob/562d335617d0f47c49c11104a7d6c5bab1db9d09/tests/test_scoring.py#L100-L104

I don't understand why npt.assert_equal(report["Total burst duration"], 15) should actual be valid. 15 is the length of the vector but not all are actual bursts (e.g. FALSE at the begginning)

Also, I need your help to do the pytest for the MEMA report,

https://github.com/lkorczowski/Tinnitus-n-Sleep/blob/562d335617d0f47c49c11104a7d6c5bab1db9d09/tests/test_scoring.py#L107-L123

Very weird for the first problem with npt.assert_equal(report["Total burst duration"], 15) On my side there is no problem, the test works!

For the other issue, it was a simple one as well : you made 2 episodes of MEMA, one of duration 8 and the other of dduration 7, so the mean duration was 7.5. You were maybe tired!

RobinGuillard commented 4 years ago

Sorry for closing the PR, it wasn't intentional!