RobinGuillard commented 4 years ago

Here is my new "OMA_detect" implementation to detect movements and label them as artefacts before bruxism or MEMA detection.

Important: there are 1 optimization I wish to do but, it will imply consequences:

as we made the check impedance algo optional, we should put the imp_chan input of the function as optional too. But due to our coding, it's not the case now. Currently, if we want to use preprocess, we have to put a list of channel (even empty), that's not optimal.
Making this change will have as consequence to modify on each notebook the inputs of preprocess, it's tricky.

codecov[bot] commented 4 years ago

Codecov Report

Merging #64 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        13    +1     
  Lines          598       622   +24     
=========================================
+ Hits           598       622   +24

Impacted Files	Coverage Δ
tinnsleep/OMA_detection.py	`100.00% <100.00%> (ø)`
tinnsleep/create_reports.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faaca9c...a5b3bec. Read the comment docs.

lkorczowski commented 4 years ago

closing and see #67

lkorczowski / Tinnitus-n-Sleep

Feat oma #64

Codecov Report