lkorczowski / Tinnitus-n-Sleep

Detecting events in sleeping tinnitus patients
MIT License
1 stars 0 forks source link

Refactor preprocess #67

Closed lkorczowski closed 4 years ago

lkorczowski commented 4 years ago

other refactors

closes #71 closes #74 closes #70

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          597       636   +39     
=========================================
+ Hits           597       636   +39     
Impacted Files Coverage Δ
tinnsleep/events/burst.py 100.00% <ø> (ø)
tinnsleep/classification.py 100.00% <100.00%> (ø)
tinnsleep/events/__init__.py 100.00% <100.00%> (ø)
tinnsleep/events/episode.py 100.00% <100.00%> (ø)
tinnsleep/events/scoring.py 100.00% <100.00%> (ø)
tinnsleep/reports.py 100.00% <100.00%> (ø)
tinnsleep/signal.py 100.00% <100.00%> (ø)
tinnsleep/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6486a19...6486a19. Read the comment docs.

lkorczowski commented 4 years ago

just for fun on np.random.randn(20, 40000)

Impedance_thresholding_sliding time execution: 4.82ms
AmplitudeThresholding (including epoching) time execution: 0.53ms

10 times faster

on np.random.randn(200, 400000)

Impedance_thresholding_sliding time execution: 717ms
AmplitudeThresholding (including epoching) time execution: 45ms

yep, still 10 times faster