RobinGuillard commented 4 years ago

Weird bug with pytesting, not finding generate_bruxism_report...

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

codecov[bot] commented 4 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          597       654   +57     
=========================================
+ Hits           597       654   +57

Impacted Files	Coverage Δ
tinnsleep/create_reports.py	`100.00% <100.00%> (ø)`
tinnsleep/scoring.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16ab237...3e1390a. Read the comment docs.

lkorczowski commented 4 years ago

@RobinGuillard please merge this PR directly into #67 instead because my pytest fails due to burst_to_episode not working properly (#72 )

lkorczowski commented 4 years ago

@RobinGuillard : it is not clear at all what does this pull request ? It doesn't look like but changed should have been merged with #67. So it is definitely a problem here and it is hard to tell how to merge it has there is no description of the goal of this pull request.

lkorczowski commented 4 years ago

@RobinGuillard OK this branch is a nightmare to manage the conflicts. Please delete this branch and if there are usefull commit to scrapt, add it manually with a new branch from master.

Closing.

lkorczowski / Tinnitus-n-Sleep

Combine-brux-mema #68

Codecov Report