lkorczowski / Tinnitus-n-Sleep

Detecting events in sleeping tinnitus patients

MIT License

1 stars 0 forks source link

refactor NB for softcoded sfreq #85

Closed lkorczowski closed 4 years ago

lkorczowski commented 4 years ago

[x] softcoded sfreq Bruxism inter
[x] softcoded sfreq MEMA inter
[x] refactor bruxism intra-subject
[x] refactor MEMA intra-subject
[x] clean combine NB
[x] combine MEMA and bruxism computation into a single script #88 .
[x] combine NB: fix management of bruxism and MEMA files when only one is available
[x] check_annotation.py script for loading results and visualization of the annotations
[x] merged annotation with new parameters merge in data.AnnotateRaw_sliding
[x] remove power ratio error when to valid epoch #89
[x] updated script compute_results.py to deal with too strict artifact detection #90

closes #37 closes #84 closes #87 closes #88 closes #89 closes #90

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

codecov[bot] commented 4 years ago

Codecov Report

Merging #85 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #85   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          680       680           
=========================================
  Hits           680       680

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39df9bb...39df9bb. Read the comment docs.

lkorczowski commented 4 years ago

@RobinGuillard I couldn't make the analysis of the results for combine because of time but the rest is working. You need to run the script on your compute and push the new .pk first.

You can run the following script in the second cell of the combine NB:

%run ../compute_results.py --bruxism True --mema True --overwrite True

Note the --overwrite True that will overwrite the results, without doing that, the script will do nothing.

review-notebook-app[bot] commented 4 years ago

View / edit / reply to this conversation on ReviewNB

RobinGuillard commented on 2020-05-25T13:38:51Z ----------------------------------------------------------------

Useless definition of parameters : EDF_list is not passed to the script, result file is used only once when importing results, it should be placed in the cell of importation of the results