search

lkorczowski / Tinnitus-n-Sleep

Detecting events in sleeping tinnitus patients
MIT License
1 stars 0 forks source link

Clean nb #95

Closed lkorczowski closed 4 years ago

lkorczowski commented 4 years ago

closes #94

review-notebook-app[bot] commented 4 years ago

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will decrease coverage by 1.52%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #95      +/-   ##
===========================================
- Coverage   100.00%   98.47%   -1.53%     
===========================================
  Files           11       11              
  Lines          680      654      -26     
===========================================
- Hits           680      644      -36     
- Misses           0       10      +10
Impacted Files Coverage Δ
tinnsleep/events/scoring.py 85.07% <ø> (-14.93%) :arrow_down:
tinnsleep/events/burst.py 100.00% <100.00%> (ø)
tinnsleep/reports.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cd123a...ba6531e. Read the comment docs.

RobinGuillard commented 4 years ago

I have reviewed your code and everything seems good to me. I must admit I don't know why the coverage test doesn't work, the only explaination is that the coverage did not pass even before you started modifications... Which would be weird... Likeoften, I cannot access to the coverage report so I'll let you chack out which line is not tested.

lkorczowski commented 4 years ago

@RobinGuillard to review and merge before #98