lkosson / full-address-column

Thunderbird add-on to show full sender and recipient address column in message list
MIT License
38 stars 9 forks source link

Not working with Thunderbird 115.0b4 #14

Open michalwoz opened 1 year ago

michalwoz commented 1 year ago

Hi,

May I ask to check if there is significant change that prevent from working with 115.0b4?

lkosson commented 1 year ago

Hi. It seems Mozilla has completely redesigned (yet again) internals of message pane in Thunderbird 114, along with some other hideous UI changes. If those changes make it to ESR/release channel, the addon will be officially dead.

lkosson commented 1 year ago

Issues to track:

https://phabricator.services.mozilla.com/D179632 https://bugzilla.mozilla.org/show_bug.cgi?id=1817682 https://bugzilla.mozilla.org/show_bug.cgi?id=1615801

Discussions: https://thunderbird.topicbox.com/groups/addons/Te5f62259df8c0c74 https://thunderbird.topicbox.com/groups/addons/T3c6ef3b787f59129

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 1 year ago

not working on stable 115.0 any alternative or can it be fixed?

lkosson commented 1 year ago

No workarounds or alternatives at this point. I don't think it's possible to reliably add custom columns until https://phabricator.services.mozilla.com/D179632 gets merged.

lsr1 commented 9 months ago

The fact that an EMAIL client has no possibility to display the sender EMAIL address (w/o a third party tool) is so infuriating.

I wonder who makes those decisions.

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 9 months ago

The fact that an EMAIL client has no possibility to display the sender EMAIL address (w/o a third party tool) is so infuriating.

I wonder who makes those decisions.

ya don't worry. that email that you got from coinbase urging you to send all your crypto to that address is legit, because the name says so ! fkn dumb mozilla

lones commented 9 months ago

Very sorry to see this is no longer possible. To see the email address of the sender is essential.

gss0 commented 9 months ago

https://connect.mozilla.org/t5/ideas/new-column-for-e-mail-adress-of-sender/idi-p/38300

olfMombach commented 9 months ago

The fact that an EMAIL client has no possibility to display the sender EMAIL address (w/o a third party tool) is so infuriating.

I wonder who makes those decisions.

I know right? And how come so few people are talking about this? Also I can't wrap my head around how this decision was taken in the design process. It's such a vital part for visually scanning mails for malicous intent, I'd regard it as an essential security feature. Makes me wonder if someone on the board came from a spammail provider.

shalak commented 9 months ago

From what I understand on 2023-09-16 John Bieling picked this task to be fixed, so there's hope what this will be fixed soon, right? Right?

benintech commented 9 months ago

Nothing new to add, I'm just another unhappy TB user here, missing the ability to see the sender's email address. I switched back to a previous version of TB, with full address column extension, until this feature works again one way or another in TB115+. I hope with all those unhappy TB users something will be done about it.

ghost commented 9 months ago

Temporary solution: Downgrade to 102 version https://www.companionlink.com/support/kb/How_to_downgrade_ThunderBird_Supernova_115_to_Regular_Thunderbird_102_Email

dracken commented 8 months ago

Temporary solution: Downgrade to 102 version https://www.companionlink.com/support/kb/How_to_downgrade_ThunderBird_Supernova_115_to_Regular_Thunderbird_102_Email

Can confirm following the steps in this link to revert back to v102 does work and will allow usage of incompatible plugins with v115.

lkosson commented 7 months ago

Also worth tracking: https://bugzilla.mozilla.org/show_bug.cgi?id=243258

jeppe-at-acapire-se commented 7 months ago

Ping! Just to make sure this isn't forgotten.

olfMombach commented 7 months ago

Ping! Just to make sure this isn't forgotten.

Why would they forget about it? They were literally killed off completely by Mozilla's TB Update

GoldMath commented 6 months ago

It's still beyond me that mail clients don't have that native, it's the best against phishing attacks as you can quickly check source instead of these fake names... I'm really looking for an alternative now; thanks for your work sadly shutdown.

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 6 months ago

As a workaround, I enabled sender full address in the message (right) pane as well as all the extra headers. See my settings below on Thunderbird v115.6: Screenshot 2023-12-24 000110

This helps me identify spoofed sender addresses and also to identify to which of my aliases they sent by quickly scrolling a bit down.

Eg. these guys are impersonating Coinbase and are hiding the to address:

Screenshot 2023-12-24 000124

Look for Received and X-Apparently-To headers. Eg.:

From - Thu Nov 02 19:59:36 2023
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
X-Mozilla-Keys:                                                                                 
Received: from 127.0.0.1
 by atlas-production.v2-mail-prod1-bf1.omega.yahoo.com pod-id atlas--production-bf1-5466855f66-4c7zp.bf1.yahoo.com with HTTP; Thu, 2 Nov 2023 11:00:31 +0000
Return-Path: <signsecpp@t-online.de>
X-Originating-Ip: [194.25.134.21]
Received-SPF: pass (domain of t-online.de designates 194.25.134.21 as permitted sender)
Authentication-Results: atlas-production.v2-mail-prod1-bf1.omega.yahoo.com;
 dkim=unknown;
 spf=pass smtp.mailfrom=t-online.de;
 dmarc=unknown header.from=t-online.de;
X-Apparently-To: my_email@yahoo.com; Thu, 2 Nov 2023 11:00:32 +0000
X-YMailISG: <redacted>
Received: from 194.25.134.21 (EHLO mailout10.t-online.de)
 by 10.197.39.167 with SMTPs
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256);
 Thu, 02 Nov 2023 11:00:31 +0000
Received: from fwd80.aul.t-online.de (fwd80.aul.t-online.de [10.223.144.106])
    by mailout10.t-online.de (Postfix) with SMTP id 56323432D4;
    Thu,  2 Nov 2023 12:00:08 +0100 (CET)
Received: from spica14.mgt.mul.t-online.de ([172.20.102.121]) by fwd80.aul.t-online.de
    with esmtp id 1qyVQV-3IBMY40; Thu, 2 Nov 2023 12:00:00 +0100
Received: from 172.86.100.180:48442 by cmpweb03.aul.t-online.de with HTTP/1.1 (Lisa V7-6-7-2.0 on API V5-53-2-0); Thu, 02 Nov 23 11:59:51 +0100
Received: from 172.20.102.129:11468 by spica14.mgt.mul.t-online.de:8080; Thu, 2 Nov 2023 11:59:51 +0100 (CET)
Date: Thu, 2 Nov 2023 11:59:51 +0100 (CET)
From: Coinbase <signsecpp@t-online.de>
Sender: Coinbase <signsecpp@t-online.de>
Reply-To: Coinbase <signsecpp@t-online.de>
To: "verifyacct@coinbasesupport.com" <verifyacct@coinbasesupport.com>
Message-ID: <1698922791404.2519176.60f84ccd77dfea669f6a24cb14646e595e526259@spica.telekom.de>
Subject: Reminder: Verify Your Recent Transactions
MIME-Version: 1.0
Content-Type: multipart/alternative; 
    boundary="----=_Part_3068892_1500834053.1698922791544"
X-UMS: email
X-TOI-EXPURGATEID: 150726::1698922800-597F5ED2-54397B3D/10/25641583394 SUSPECT URL
X-TOI-MSGID: 271cba03-5db1-437e-9bd4-eb4f3d98512e
lkosson commented 6 months ago

Good news, everyone! Thanks to the new API included in this daily build, the add-on is working again. I'll upload the updated version as soon as new TB version is released.

Zwiebelring2000 commented 5 months ago

Is there a release date?

lkosson commented 5 months ago

No idea.

CEWebDesign commented 5 months ago

Next Thunderbird release 115.7 should be January 23 2024: https://wiki.mozilla.org/Releases "Thunderbird approximately (i.e. not strictly) follows the ESR schedule listed there." https://whattrainisitnow.com/calendar/ (Matching ESR)

lkosson commented 5 months ago

Required changes have not been merged into neither Daily nor Beta Thunderbird. I don't expect them to be included in a proper release any time soon.

aspx1981 commented 5 months ago

Hello, sorry I don't understand, I updated Thunderbird, now how can I install the new version with the new API ? Thanks

lkosson commented 5 months ago

You can't. It's not yet released.

ivan-paleo commented 5 months ago

So it won't work with the newly released 115.7.0?

lkosson commented 5 months ago

No, it won't.

Martin511 commented 4 months ago

Maybe it will work with the new 115.8.0? "Asking for a friend"

lkosson commented 4 months ago

No idea. As far as I can tell, we're currently waiting for this issue and this changeset.

doodhout commented 4 months ago

One of the latest comments in the linked issue states the following:

Once it reached beta on the 19th, add-on developers can adjust their add-ons and test custom column support for their add-ons for Thunderbird Beta.

That means you should be able to test this add-on in the Thunderbird Beta starting from 2024-02-19.

If I find a quick way to install TB Beta alongside TB Stable on my linux installation, I might test this myself and report back.

lkosson commented 4 months ago

I currently have side-by-side versions 102.15.1 (prev release), 115.8.0 (release), 124.0b1 (beta from 2024-02-19) and 125.0a1 (daily from 2024-02-22). None of those versions have this API available. The only version with support for custom columns was the one I've linked to in comment from 2023-12-23.

Martin511 commented 4 months ago

👉🏻 https://bugzilla.mozilla.org/show_bug.cgi?id=1615801#c19

Martin511 commented 3 months ago

Are there any news on this?

lkosson commented 3 months ago

Nope. Just some activity here yesterday.

MilesTeg81 commented 3 months ago

As a workaround, I enabled sender full address in the message (right) pane as well as all the extra headers. See my settings below on Thunderbird v115.6: Screenshot 2023-12-24 000110

This helps me identify spoofed sender addresses and also to identify to which of my aliases they sent by quickly scrolling a bit down.

[...]

wow, I completely missed this setting! thx a lot!!

This (combined with DKIM verifier) already makes a huge difference! (Though I still can't wait for a working column option...)


btw. Apart from the mentioned bugzilla, it's still possible to VOTE here:

I know, current state: "we are nearly there". But that was also the case 20 years ago... :/

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 3 months ago

As a workaround, I enabled sender full address in the message (right) pane as well as all the extra headers. See my settings below on Thunderbird v115.6: Screenshot 2023-12-24 000110 This helps me identify spoofed sender addresses and also to identify to which of my aliases they sent by quickly scrolling a bit down.

[...]

wow, I completely missed this setting! thx a lot!!

This (combined with DKIM verifier) already makes a huge difference! (Though I still can't wait for a working column option...)

btw. Apart from the mentioned bugzilla, it's still possible to VOTE here:

I know, current state: "we are nearly there". But that was also the case 20 years ago... :/

Thank also for sharing the DKIM verifier addon. It's really useful.

pstein commented 3 months ago

As a workaround, I enabled sender full address in the message (right) pane as well as all the extra headers. See my settings below on Thunderbird v115.6: Screenshot 2023-12-24 000110 This helps me identify spoofed sender addresses and also to identify to which of my aliases they sent by quickly scrolling a bit down.

Cannot view your screenshot since it seems to be private. Can you add it here publicly? Where can I add this option?

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 3 months ago

As a workaround, I enabled sender full address in the message (right) pane as well as all the extra headers. See my settings below on Thunderbird v115.6: Screenshot 2023-12-24 000110 This helps me identify spoofed sender addresses and also to identify to which of my aliases they sent by quickly scrolling a bit down.

Cannot view your screenshot since it seems to be private. Can you add it here publicly? Where can I add this option?

scroll up to my post, it should be visible

lkosson commented 2 months ago

As of Thunderbird 115.10.0, internal API to manipulate columns is available (details here). However, public API (available to normal add-ons) is still missing and - as per recent comment - there even is no roadmap to release it.

I have published new version of Full Address Column - it's awaiting a review and should be available soon. It works with Thunderbird 115.10.0, but uses experimental API. This means the add-on is unrestricted and requires full permissions. Decide on your own if you trust it.

Also, on Thunderbird Daily (127, 2024-05-02) there is now native option to see raw Email in Correspondents/Sender/Recipient column.

New version (1.1.0) does not work with Thunderbird 102 - if you still use it, stay on version 1.0.4 from last year.

Uj947nXmRqV2nRaWshKtHzTvckUUpD commented 2 months ago

where can we test v1.1.0 and any rough idea how long should we wait for the change (v115 -> v127) ?

lkosson commented 2 months ago

It is still awaiting a review at https://addons.thunderbird.net/ - usually it takes between a few minutes and a few days.

I can't upload .zip or .xpi to github - if you wish to install the add-on manually, zip all the files in src directory, change the extension to .xpi and use "Install add-on from file" in TB.

Martin511 commented 2 months ago

This is working so far - thank you for updating! In my case the function to sort the column @sender does not work. Ist this bug known?

lkosson commented 2 months ago

I have just fixed sorting - version 1.1.2 awaits review.

olavsu1 commented 1 month ago

At first startup it don't load colums correctly. Closing and reopening the Thunderbird window helps until next time. Because after a long pause when starting thunderbird the columns are messed up again. Columns title and content do not match. Thanks.

sebma commented 1 month ago

I have just fixed sorting - version 1.1.2 awaits review.

Hi, I could not install on Thunderbird v115.9.0.

After updating the thunderbird ubuntu package (upto v115.11.0), I was able to install the extension :smile:

dom6770 commented 2 weeks ago

At first startup it don't load colums correctly. Closing and reopening the Thunderbird window helps until next time. Because after a long pause when starting thunderbird the columns are messed up again. Columns title and content do not match. Thanks.

I have the same issue on my personal Thunderbird profile, though not on my work profile, which is odd. When I open Thunderbird the columns headers are in the correct order, but the actual content of the mail is all over the place. When I deactivate the extension, this bug disappears. Sometimes I need to reopen Thunderbird up to 10 times until it's normal again.

Should we open a issue for that? Next time it happens I can make a video.

lkosson commented 2 weeks ago

I might have seen this behavior once in Beta, but not ever since. Without a reliable way to reproduce it, I doubt I can do anything about it, even with a video. When it does reoccur, please check console (CTRL-SHIFT-J) for anything interesting.

You can open a new issue to keep things clean and on-topic in this one.