search

lkrg-org / lkrg

Linux Kernel Runtime Guard
https://lkrg.org
Other
404 stars 72 forks source link

CI: mkosi: Do not assume grub is installed #228

Closed vt-alt closed 1 year ago

vt-alt commented 1 year ago

mkosi' "--boot-protocols is deprecated and has no effect anymore", thus do not assume we will be booting using grub/bios.

Fixes: https://github.com/lkrg-org/lkrg/issues/227

[Not fully tested locally — will see GA report here.]

solardiz commented 1 year ago

[Not fully tested locally — will see GA report here.]

It's all green, so I'll merge. Thank you!

solardiz commented 1 year ago

Looks like mkosi-mainline now loads LKRG pretty late via modprobe. Wasn't it previously loaded early, from initrd?

Welcome to Ubuntu Kinetic Kudu (development branch) (GNU/Linux 6.0.0-060000rc2daily20220824-generic x86_64)

 * Documentation:  https://help.ubuntu.com/
 * Management:     https://landscape.canonical.com/
 * Support:        https://ubuntu.com/advantage
Last login: Fri Sep  2 07:01:37 UTC 2022 on tty1
[   73.427101] kvm: Nested Virtualization enabled
[   73.427443] SVM: kvm: Nested Paging enabled
[   73.428037] SVM: Virtual GIF supported
[   73.428235] SVM: PMU virtualization is disabled
root@localhost:~# /lkrg/.github/workflows/run-boot-tests.sh
+ '[' '!' -d /sys/module/lkrg ']'
+ modprobe lkrg
[   77.363510] lkrg: loading out-of-tree module taints kernel.
[   77.370299] lkrg: module verification failed: signature and/or required key missing - tainting kernel
[   77.627519] LKRG: ALIVE: Loading LKRG
solardiz commented 1 year ago

Looks like mkosi-mainline now loads LKRG pretty late via modprobe.

and the same for e.g. mkosi-boot (bionic) and probably for all of them. Looks like a regression.