lkrg-org / lkrg

Linux Kernel Runtime Guard
https://lkrg.org
Other
404 stars 72 forks source link

pINT: Make the real_cred check in p_cmp_tasks() unconditional #242

Closed solardiz closed 1 year ago

solardiz commented 1 year ago

Fixes #240

Description

We were only performing a check of real_cred conditionally - only if we had already detected another discrepancy. @Adam-pi3 and I couldn't recall a reason for this limitation, so I tried removing the condition, and things seem fine.

How Has This Been Tested?

Our CI tests are happy (except RHEL8, which currently can't be tested - pending another fix). Also, no issues when installed in an old Fedora VM with some light usage.

solardiz commented 1 year ago

This probably has some slight performance impact, but it's probably a kind of check that we want to perform anyway.