lkrg-org / lkrg

Linux Kernel Runtime Guard
https://lkrg.org
Other
402 stars 72 forks source link

CI: Update workflows to use latest versions of the actions #285

Closed vt-alt closed 10 months ago

vt-alt commented 10 months ago

This should quiet the warning:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

vt-alt commented 10 months ago

Hmm, openSUSE builds also got broken (missing awk ~and git~ in their runs). perhaps this is unrelated to actions update and related to some docker image update since previous successful docker build was long 3 weeks ago. I will try add commit with a fix later to this PR.

solardiz commented 10 months ago

I will try add commit with a fix later to this PR.

Thank you, @vt-alt! I assume this is not to be merged yet?

vt-alt commented 10 months ago

I filed issue into GH checkout/action but they did not reply. This mean we will be not able to retain opensuse/leap for tests. If you are OK with it, I will add commit deleting it.

opensuse/tumbleweed fixes if we add gawk to zypper install.

ps. I said before 'it misses git' but I was incorrectly identified problem att.

solardiz commented 10 months ago

we will be not able to retain opensuse/leap for tests. If you are OK with it, I will add commit deleting it.

I would be OK with it if there were a better reason to do it, but removing a currently working test just to silence a warning does not feel like a good tradeoff. Do I understand this correctly? What do you think?

vt-alt commented 10 months ago

Them we shall not merge it and postpone this until tests really fail with v1.

vt-alt commented 10 months ago

Perhaps they started to use tar from inside of contained in @v3, and leap image does not have it (but tumbleweed have it). So if I install tar and gzip (and reorder steps) build starting to work again. I reopen, and will push fixed version later today.

vt-alt commented 10 months ago

Can be merged now I think.