search

lksv / node-resemble.js

LOOKING FOR MAINTAINER - Image analysis and comparison
MIT License
99 stars 37 forks source link

rawMismatch + fix tests #37

Closed darkartur closed 7 years ago

mirzazeyrek commented 7 years ago

Hello @darkartur,

Thank you for your PR. Is it possible if you could close this one and send all the related changes in 1 commit based from latest version of original master branch ?

lksv commented 7 years ago

Hi, Thank you for this PR too. It's perfect. I would prefer to keep following three commits as is:

  |  Ignore JetBrains IDE files | c44816d   |  rawMisMatchPercentage feature | da497ea   |  Fix initial color for diff | 1fddc71

(e.g. not to sqash them together). Because they fixes/implements individual features.

But please remove commits aa3f862 and 5f278a5. You can do it by git reset --hard 1fddc7123bd2f53e465f3a1cbdcf0d3a9d30533a; git push -f in your foked master.

darkartur commented 7 years ago

Done

darkartur commented 7 years ago

Guys?

z-vr commented 7 years ago

hello @mirzazeyrek @lksv do you mind merging the PR pleas?

mirzazeyrek commented 7 years ago

Merged. Thank you.

darkartur commented 7 years ago

@mirzazeyrek @lksv can u publish new version to NPM please?

mirzazeyrek commented 7 years ago

@lksv Can we update npm ?