search

lksv / node-resemble.js

LOOKING FOR MAINTAINER - Image analysis and comparison
MIT License
99 stars 37 forks source link

pngjs package version update #43

Closed afzydev closed 6 years ago

afzydev commented 6 years ago

Hi

Thanks for the awesome package to compare image.

There are some missing updates in a package pngjs in file i.e _/node_modules/node-resemble-js/node_modules/pngjs/lib/bitmapper.js file_ and function mapImage8Bit

There are missing line of code in the previous version of package i.e

var idx = pixelBppMap[bpp][i];
        if (idx === 0xff) {
          pxData[pxPos + i] = 0xff;
        } else {
          var dataPos = idx + rawPos;
          if (dataPos === data.length) {
            throw new Error('Ran out of data');
          }
          pxData[pxPos + i] = data[dataPos];
        }

So we need to update the version of this package to resolved the issue in their previous releases.

So, I have updated the package pngjs in your package.json of node-resemble.js.Please update to resolve future issues.

Thanks

Regards afzydev

lksv commented 6 years ago

Thanks!