search

lksv / node-resemble.js

LOOKING FOR MAINTAINER - Image analysis and comparison
MIT License
99 stars 37 forks source link

tolerance is not publicly accessible #7

Open kzndzhiro opened 9 years ago

kzndzhiro commented 9 years ago

Hi Lukas, Great job on removing the dependencies and using pngjs. It is perfect solution for my project. I have a a suggestions though. I would like to be able to change the tolerance settings because to my knowledge I can not do that right now. I need that option for the tool to, so it can be more accurate with colors. I have couple of ways doing that and if you would like I can submit a pull request for you to see what I have in mind it is really a small change.

Thanks again for the great tool!

graingert commented 6 years ago

@kazandzhiro can you re-open this

graingert commented 6 years ago

@lksv can you take a look at this?

kzndzhiro commented 6 years ago

@graingert Sure. I have forked and made the changes in here node-resemble-js

gtway commented 6 years ago

Hi Lukas, you have written very useful package, Great job! @lksv, is it possible to add method for custom setting of the tolerance to your code? Have you any plan for this? @kazandzhiro wrote a good solution, but he doesn't use jpeg in his package. And it's better to have the code in one place instead of search and request many different packages. I've sent a pull-request for this change.

mikhail-g commented 11 months ago

I fix the issue with tolerance by updating ignoreNothing() that, I believe, was originally created to have 0 tolerance. And also it's how it currently working in the original resemblejs Feel free to use my solution in the fork on npm: @mikhail-g/node-resemble-js