lkucharczyk / mediawiki-PortableInfobox

Port of Fandom's https://github.com/Wikia/app/tree/dev/extensions/wikia/PortableInfobox extension to the MediaWiki 1.32+
GNU General Public License v3.0
11 stars 9 forks source link

Use of BeforeParserrenderImageGallery hook... was deprecated in MediaWiki 1.35. #43

Open The-Voidwalker opened 3 years ago

The-Voidwalker commented 3 years ago

The release notes indicate there is no replacement, so I'm not certain what needs to be do fix. Though, a vague recommendation is made that "MediaHandler provides for customizable media rendering", which may or may not prove useful here.

lkucharczyk commented 3 years ago

I would need another way to grab image data from gallery strip markers then. https://github.com/lkucharczyk/mediawiki-PortableInfobox/blob/eb05dd29d15dd4b6659aa3a7d9abf84576e57798/includes/services/Parser/Nodes/NodeMedia.php#L32-L40

I guess I could scrape parsed HTML, just like in tabber (same file; method below), but I would prefer a more elegant approach, so I leave that as a last resort.