search

lkundrak / dev86

C compiler, assembler and linker environment for the production of 8086 executables
http://v3.sk/~lkundrak/dev86/
GNU General Public License v2.0
153 stars 44 forks source link

merge patches from Gentoo #16

Open jonasstein opened 6 years ago

jonasstein commented 6 years ago

Hi, I just saw that we have some patches on Gentoo Linux, which are not yet merged upstream. https://github.com/gentoo/gentoo/tree/master/sys-devel/dev86/files They fix for example a bug with clang. https://bugs.gentoo.org/show_bug.cgi?id=523096

mfld-fr commented 6 years ago

Hello @jonasstein, thanks for the patch report. Indeed, @lkundrak looks like to be now inactive on this dev86 mainstream. Could you please tell us why you need such patches ? We could consider merging them in @jbruchon fork.

jonasstein commented 6 years ago

@mfld-fr I am not the maintainer of the package, nor did I write the patches. So I know only what is written there in the commit logs/comments. One enables compilation with clang for example.

mfld-fr commented 6 years ago

@jonasstein : I understand, but I am afraid you did not respond to the question : is it worth to merge these patches, i.e. do you actually need them ?

jonasstein commented 6 years ago

@mfld-fr For our Gentoo users we distribute the source together with the patches and compile the software on the users machine. So it is not urgent for Gentoo users. But I think especially the very simple clang fix could be interesting for everybody, since clang gets more and more important and more strict towards some code mistakes.

mfld-fr commented 6 years ago

@jonasstein : By "our users", should I understand you are a member of the Gentoo team ? Actually the patch for clang has already been submitted in PR #14, and merged in @jbruchon fork.