search

lkuza2 / java-speech-api

The J.A.R.V.I.S. Speech API is designed to be simple and efficient, using the speech engines created by Google to provide functionality for parts of the API. Essentially, it is an API written in Java, including a recognizer, synthesizer, and a microphone capture utility. The project uses Google services for the synthesizer and recognizer. While this requires an Internet connection, it provides a complete, modern, and fully functional speech API in Java.
GNU General Public License v3.0
535 stars 304 forks source link

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #80

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule common-java:DuplicatedBlocks - Source files should not have any duplicated blocks. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks Please let me know if you have any questions. George Kankava

Skylion007 commented 8 years ago

Thx again for the code cleaning. :)

georgekankava commented 8 years ago

@Skylion007 It has a little problem with maven-javadoc-plugin while mvn clean package. Seems it doesn't like new addition. I don't have much experience with that plugin. Hope you will handle that easier or if not please let me know and I will take a look later.

Skylion007 commented 8 years ago

Ah you mean the previous maven addition? I don't see any changes to maven in the pull request? Unfortunately, I don't have a terrible amount of experience with maven either.

Skylion007 commented 8 years ago

Ah so this isn't an issue with Maven at all. Javadocs will just crash with malformed Javadocs. If we fix the JavaDoc lines its complaining about, Maven should work just fine.To fix this we just need to add a string after the errors it is throwing. For instance, @throws LineUnavailableException must have a string following it explaning why it throws that. Simply having @param paramname is insufficient. I'll open an issue to track this.

Skylion007 commented 8 years ago

Moving this issue to #81