Add support for gulpfile.babel.js and test

lkytal / quickTask

Task runner and manager extension for VSCode

https://lkytal.github.io/quickTask/

GNU Affero General Public License v3.0

11 stars 7 forks source link

Closed flying-sheep closed 7 years ago

flying-sheep commented 7 years ago

there’s a problem: to test gulpfile.js, you need gulp v3 installed, to test gulpfile.babel.js, you need gulp v4 installed.

seem like your tests aren’t working at all.

PS: if you want to test gulpfile.babel.js, you also need babel-register and babel-plugin-transform-es2015-modules-commonjs

nealoke commented 7 years ago

+1 for this #13

flying-sheep commented 7 years ago

OK, so turns out the code actually expects strings for the glob patterns, not arrays.

i adapted the settings accordingly in 89de4d2250f566f3dd1b08e0c77b04272e8a680b
path.relative can return "", but the code only checks if (result.relativePath != null). this is a problem because plain cd is the same as cd ~. so i made sure relativePath is never empty cb9487f0809ab318e6eb8629b4a2237ad7b1758e

lkytal commented 7 years ago

Thanks.

flying-sheep commented 7 years ago

no problem! but you should make sure that your tests run!

i get errors in some of them (unrelated to my changes)