procession does not trash duration cards

[GoogleCodeExporter]

There are two problems.  The first is functional (the duration card is not 
trashed), while the second is just cosmetic (Procession is not shown in the 
played cards area on the second turn).

What steps will reproduce the problem?
1. Play Procession
2. Choose a duration card (for example, Caravan)

What is the expected output? What do you see instead?

Expected:
1. Caravan is played twice.  +1 action +1 card each time.
2. Trash Caravan.
3. Gain a card costing exactly 5.
** next turn **
4. (Procession remains in play from previous turn.)
5. Caravan is played twice.  +1 action +1 card each time.

Actual:
-Caravan is not trashed in step 2.  
-Procession correctly remains in play until the next turn, but is not shown in 
the played cards area.

Original issue reported on code.google.com by August.D...@gmail.com on 20 Oct 2012 at 9:35

[GoogleCodeExporter]

From the Dark Ages rulebook:
"If you use Procession on a Duration card (from Seaside),
Procession will stay out until your next turn and the Duration
card will have its effect twice on your next turn, even though the
Duration card is trashed."

Original comment by August.D...@gmail.com on 20 Oct 2012 at 10:01

[GoogleCodeExporter]

tl,dr: This is fixed in r707

I tested the following scenarios:

* Procession-MerchantShip
1. MerchantShip played twice
2. MerchantShip trashed
3. card costing exactly 6 gained
4. Procession and MerchantShip wait in the players NextTurn list 
** next turn **
5. Procession remains in play from previous turn (before moving to discard pile)
6. MerchantShip played twice, then disappears (moved to trash in previous turn).

* Procession-Procession-MerchantShip-MerchantShip
1. 2nd Procession played twice:
  a. MerchantShip played twice
  b. MerchantShip trashed
  c. card costing exactly 6 gained
  d. MerchantShip played twice
  e. MerchantShip trashed
  f. card costing exactly 6 gained
2. 2nd Procession trashed
3. card costing exactly 5 gained
4. 1st Procession and 2 MerchantShips wait in the players NextTurn list 
** next turn **
5. 1st Procession remains in play from previous turn (before moving to discard 
pile)
6. 2 MerchantShips each play twice, then disappear (moved to trash in previous 
turn)

I think some cards are still getting lost because my card counts don't always 
add up correctly at game end when I add ThroneRoom and GraveRobber into the 
supply. Let me know if you see a particular pattern - otherwise I'll just try a 
few more scenarios before closing issue.

Original comment by tkden...@gmail.com on 30 Oct 2012 at 7:01

• Changed state: Started
• Added labels: Component-Core

[GoogleCodeExporter]

Looks good to me.  I tried a bunch of stuff, including the scenario you tested, 
and everything seems correct.  I didn't see any weird card counts at the end of 
the game, but I'll keep an eye out for that sort of thing.

Original comment by August.D...@gmail.com on 30 Oct 2012 at 3:40

[GoogleCodeExporter]

Fixed r719

Original comment by tkden...@gmail.com on 12 Nov 2012 at 4:34

• Changed state: Fixed