Closed JuliusMiller closed 4 weeks ago
The changes involve modifications to the RobotEnv
, PedestrianEnv
, and various example scripts. Specifically, the reset
and step
methods have updated return types and values to improve consistency. The VisualizableSimState
and SimulationView
classes have seen adjustments in attribute names and types to enhance rendering capabilities. Additionally, several example scripts have been updated to reflect these changes in method calls and to streamline import statements.
File Path | Change Summary |
---|---|
examples/demo_offensive.py | Updated training function to set recording_enabled to False . Modified return values of env.reset() and env.step(action) . |
robot_sf/gym_env/robot_env.py | Updated method signatures for reset and step to reflect new return types. |
robot_sf/gym_env/pedestrian_env.py | Enhanced reset method in PedestrianEnv to clear last actions. Updated method signature. |
robot_sf/render/sim_view.py | Renamed ego_ped_actions to ego_ped_action . Changed display_robot_info type from boolean to integer. Updated _add_text and rendering logic. |
examples/ego_ped_example.py | Adjusted env.reset() calls to unpack additional return values. Changed input map for convert_map . |
examples/simulate_with_svg_map.py | Updated observation handling and simulation environment configuration to unpack additional return values. |
examples/view_recording.py | Streamlined import statements by removing unused imports. |
Objective | Addressed | Explanation |
---|---|---|
Offensive demo simulation should work (#67) | β |
robot_sf/gym_env/robot_env.py
file regarding the reset
and step
methods are directly related to the modifications made in the main PR, which also updates these methods' signatures and return values.robot_sf/gym_env/robot_env.py
file are relevant as they involve formatting adjustments, but they do not alter the functionality or logic of the code, which is consistent with the changes made in the main PR.In the world of code, where rabbits play,
We hop through changes, brightening the day.
With actions reset and values anew,
Our simulation dances, vibrant and true.
So letβs celebrate with a joyful cheer,
For each little tweak brings the future near! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Fixed multiple Demos in example directory, + sim_view changes for only viewing the robot.
Deleted draw_timestep, because timestep is included in the info text.
Added toggle feature (press q) for the info_display: no_info -> robot_info -> pedestrian_info -> no_info -> ...
Fixes: #67 and #56
Summary by CodeRabbit
Summary by CodeRabbit
New Features
RobotEnv
andPedestrianEnv
to ensure a clean state at the start of each episode.SimulationView
, allowing for multiple states of robot information display.Bug Fixes
env.reset()
andenv.step(action)
methods for consistency.Refactor