ll7 / robot_sf_ll7

robot_sf in the ll7 namespace.
GNU General Public License v3.0
1 stars 1 forks source link

Fix demos + QoL change #68

Closed JuliusMiller closed 4 weeks ago

JuliusMiller commented 1 month ago

Fixed multiple Demos in example directory, + sim_view changes for only viewing the robot.

Deleted draw_timestep, because timestep is included in the info text.

Added toggle feature (press q) for the info_display: no_info -> robot_info -> pedestrian_info -> no_info -> ...

Fixes: #67 and #56

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve modifications to the RobotEnv, PedestrianEnv, and various example scripts. Specifically, the reset and step methods have updated return types and values to improve consistency. The VisualizableSimState and SimulationView classes have seen adjustments in attribute names and types to enhance rendering capabilities. Additionally, several example scripts have been updated to reflect these changes in method calls and to streamline import statements.

Changes

File Path Change Summary
examples/demo_offensive.py Updated training function to set recording_enabled to False. Modified return values of env.reset() and env.step(action).
robot_sf/gym_env/robot_env.py Updated method signatures for reset and step to reflect new return types.
robot_sf/gym_env/pedestrian_env.py Enhanced reset method in PedestrianEnv to clear last actions. Updated method signature.
robot_sf/render/sim_view.py Renamed ego_ped_actions to ego_ped_action. Changed display_robot_info type from boolean to integer. Updated _add_text and rendering logic.
examples/ego_ped_example.py Adjusted env.reset() calls to unpack additional return values. Changed input map for convert_map.
examples/simulate_with_svg_map.py Updated observation handling and simulation environment configuration to unpack additional return values.
examples/view_recording.py Streamlined import statements by removing unused imports.

Assessment against linked issues

Objective Addressed Explanation
Offensive demo simulation should work (#67) βœ…

Possibly related PRs

Poem

In the world of code, where rabbits play,
We hop through changes, brightening the day.
With actions reset and values anew,
Our simulation dances, vibrant and true.
So let’s celebrate with a joyful cheer,
For each little tweak brings the future near! πŸ‡βœ¨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.