search

llSourcell / Reinforcement_Learning_for_Stock_Prediction

This is the code for "Reinforcement Learning for Stock Prediction" By Siraj Raval on Youtube
641 stars 363 forks source link

new directory should be called 'models': changes for P3: credit to edwardhdlu #4

Open TImXS opened 6 years ago

TImXS commented 6 years ago
  1. In the README, you say:
    • mkdir model I think this should say:
    • mkdir models Minor point but might as well correct it!
  2. To run the train you may need to put 'python train.py ^GSPC 10 1000' (add the .py), just like for the evaluate.py. Again a minor point but might as well change it.
  3. For Python 3 compatibility, simply change all the 'print ...' statements to 'print(...)' and the 'xrange' to 'range' in all the .py files and everything should work. Maybe worth noting in the README.
  4. Can you be clearer if there are any changes from the original code by edwardhdlu - if not, why have you copied rather than forked? Thanks
Shamoonmohd commented 5 years ago

can you please help me in plotting the results on graph like author does

phantomsamurai commented 5 years ago

is " python train.py ^GSPC_2011 " the correct syntax ?

maulik2222 commented 5 years ago

yes, this is correct syntax " python train.py ^GSPC_2011 "