llakssz / CIAngel

Download GOOD CIAs on your 3DS!
189 stars 19 forks source link

Home menu close crash v0.7 #55

Closed Xenosaiga closed 8 years ago

Xenosaiga commented 8 years ago

If CIAngel is in the background and you try to close it from home menu it sticks on the "Closing Suspended Software" screen and requires a Hard Power Off to fix.

superbudvar commented 8 years ago

I've noticed this. I think it maybe that we are't hooking into the close call, meaning we just ignore the home menu indefinitely (or crash)

The fix maybe to remove aptMainLoop() so the home button doesn't work (until we have a proper fix at least)

DrakiaXYZ commented 8 years ago

Hmm, aptMainLoop is what should be returning false on exit, which I thought I had cascade all the way down to main. Might have missed something though

superbudvar commented 8 years ago

@TheDgtl I can't say for certain, but I had worked out you can't use home if your loop doesn't call it. I also spotted a hook called APTHOOK_ONEXIT[https://smealum.github.io/ctrulib/apt_8h.html#a65688ade2995260aadd4ab7539df58a6a0dad384082914a54947b2407dc5edf75](in this doc)

But I'm completely guessing, there's a distinct lack of info on this kind of thing, unless I'm not looking in the right places

DrakiaXYZ commented 8 years ago

Yeah, a lot of what I've been doing is guess work and trial and error :)

I'll take a look at this tonight, and see if I can sort out what might be going on.

DrakiaXYZ commented 8 years ago

Got a fix in the works for this

DrakiaXYZ commented 8 years ago

https://github.com/llakssz/CIAngel/pull/58