Preview of interface work

superbudvar commented 8 years ago

Hi Guys!

This is far from complete, but I thought I should submit a work in progress for you to review. It's all up-to-date, and while buggy, doesn't seem to be "crash" buggy (the keyboard glitch is really annoying me)

I've created a common.h because of linker problems; no idea if that's the right way to go, but I wanted it working sooner rather than later so you can see it and I know whether to give up pursuing this route or not

There are more comments in the commit log

Any questions/comments appreciated.

superbudvar commented 8 years ago

oh, hope you've got citro3d installed; another dependancy now

llakssz commented 8 years ago

Nice I'm going to have a look at this in a little while, excited!

DrakiaXYZ commented 8 years ago

I'll check this out after work! :)

DrakiaXYZ commented 8 years ago

Commit 330c5d0 is going to break building for other people, as it hard-codes the path to buildtools outside the project directory.

DrakiaXYZ commented 8 years ago

Left a couple of comments inline above :) Some other things I noticed:

indentation is a bit messed up in a few places (Mixed spaces and tabs)
using inline colors, I see you defined some in the header, assuming you just haven't gotten around to cleaning up the inline stuff?

Looks great so far though :+1: Let me know if you want help with anything on it :)

superbudvar commented 8 years ago

Thanks for the feedback! :+1:

The buildtools part of the commit is my bad; Shouldn't be there as that just what I had to do to get things building :smirk:

Yes; it's very much work in progress. I've switched my ide to use spaces rather than tabs, but probably a bit too late.

I've definitely not gotten to a tidy up phase, as I had a crisis as to whether it was the best way to go with things and wanted to check you guys were happy with it's direction. I have got defines for colours locally now, and done a refactor; mainly because I couldn't work out how to call stuff in main.cpp from externals, but I also think it'll help reduce merge conflicts also.

I'd love to have some help with this; I'm not proud :laughing: I'll push my recent work, but I think the next thing needed is to determine what needs to be done from here to make it a release candidate; I'm quite happy with the output of menus to be on the bottom where they haven't been "converted" but then I wonder if we should out and out replace the console too

superbudvar commented 8 years ago

Hello.

Some updates, for your consideration. Comments again please. I've addressed most of the comments so far

keyboard is still glitchly however and there are still a few magic offsets and some routines like download and installs still fall to the lower screen but I think it's in a lot better shape.

DrakiaXYZ commented 8 years ago

I'll take a look at this this weekend :+1:

DrakiaXYZ commented 8 years ago

Doesn't look like there's any output when you hit "Download wings.json" until it's reloading it
Getting some flicker on the bottom screen status bar, nothing too bad but I know someone will bring it up eventually
Getting last search screen flicker when going into search more than once (Probably due to double buffering, maybe there's a way to clear the screen buffer before we show results or before we draw the scene, haven't looked too much into it yet)
"Title/Ticket installed" shows up when svcHax isn't available, and just always says no
Closing the 3DS while downloading results in a freeze (It's so easy to re-introduce this bug)

Looking pretty good :+1:

airkingbr commented 8 years ago

nice work! Very beautiful new interface! Thanks !

superbudvar commented 8 years ago

Thanks! Hoping to get it nailed and released soon!

llakssz / CIAngel

Preview of interface work #60