llamanodes / web3-proxy

Fast loadbalancing and caching proxy for Ethereum or chains with similar JSON-RPC methods
https://llamanodes.com
GNU General Public License v3.0
153 stars 34 forks source link

Stipe get deposit history is implemented twice #183

Closed yenicelik closed 1 year ago

yenicelik commented 1 year ago

once in payment-stripe.rs , once in payment.rs (or user.rs?). Remove the duplicate implementation, can lead to bugs

yenicelik commented 1 year ago

First occurrence: https://github.com/llamanodes/web3-proxy/blob/main/web3_proxy/src/frontend/users/payment.rs#L101

Second occurrence: https://github.com/llamanodes/web3-proxy/blob/main/web3_proxy/src/frontend/users/payment_stripe.rs#L26

BlinkyStitt commented 1 year ago

/user/deposits/stripe is in use. we can delete /user/balance/stripe

BlinkyStitt commented 1 year ago

186