Closed mds1 closed 1 year ago
Another improvement could be not writing most of the action struct to storage and instead just storing a hash. On mainnet this would make things significantly cheaper, especially for actions with a lot of calldata. Though on L2 where calldata drives gas costs this would make action execution a lot more expensive (but not much more expensive than action creation) since you now have to provide a lot more calldata to execute
Adding this here https://github.com/llama-community/vertex/issues/59
First, for the
revokePolicy
method that loops over all roles:numRoles
is 255 AND the user holds 0 rolesnumRoles
is 255 AND the user holds 1 rolenumRoles
is 255 AND the user holds 255 rolesThen, from https://github.com/llama-community/vertex-v1/pull/190: