llamaxyz / llama

Llama is an onchain governance and access control framework for smart contracts.
https://llama.xyz
MIT License
47 stars 5 forks source link

feat: migrate color, logo, and metadata management to `LlamaPolicy` #416

Closed AustinGreen closed 1 year ago

AustinGreen commented 1 year ago

Motivation:

This is another step towards reducing functionality of the factory and empowering individual llama instances.

Modifications:

Result:

In the spirit of incremental progress towards a permissionless factory, this PR will still leave us with a hybrid approach. A followup PR can remove the root llama instance and reduce the factory to a single public deploy function.

github-actions[bot] commented 1 year ago

Coverage after merging austin/policy-metadata into main will be

89.33%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   LlamaCore.sol99.25%97.30%100%100%373, 615
   LlamaExecutor.sol80%50%100%100%33
   LlamaFactory.sol100%100%100%100%
   LlamaLens.sol69.23%20%100%80%151–152, 155, 155, 155–156, 156, 156–157, 157, 157, 165
   LlamaPolicy.sol100%100%100%100%
   LlamaPolicyMetadata.sol100%100%100%100%
src/accounts
   LlamaAccount.sol100%100%100%100%
src/lib
   Checkpoints.sol55.88%50%81.82%53.62%125, 179–181, 181, 181–182, 184, 187, 217, 224, 224–226, 228, 228–230, 232, 232–234, 236, 236–238, 257, 260–266, 273, 46, 46–48, 48, 48–49, 51
   ERC721NonTransferableMinimalProxy.sol72.46%72.73%72.73%72.22%102, 104, 106, 118, 190, 88, 88, 88, 90, 90, 90, 92, 92, 92, 97, 99
   LlamaUtils.sol50%25%66.67%60%11, 17, 17, 17–18
src/llama-scripts
   LlamaGovernanceScript.sol50%33.33%43.75%53.45%106–108, 115–117, 125–128, 135–137, 146–150, 157–158, 166–168, 67, 74, 74, 76, 89–90, 97–98
src/strategies
   LlamaAbsolutePeerReview.sol94.44%88.89%100%100%37, 40
   LlamaAbsoluteQuorum.sol92.86%85.71%100%100%24, 27
   LlamaAbsoluteStrategyBase.sol94.87%87.50%90.91%98.04%258, 261, 309
   LlamaRelativeQuorum.sol96.23%85.71%100%100%210, 213, 238, 329