llamaxyz / llama

Llama is an onchain governance and access control framework for smart contracts.
https://llama.xyz
MIT License
47 stars 5 forks source link

feat: Automatically queue when approval threshold is reached. #458

Closed 0xrajath closed 1 year ago

0xrajath commented 1 year ago

https://github.com/spearbit-audits/review-llama2/pull/1#discussion_r1274932483

TO BE DISCUSSED: Is this something we want or keep as-is for ensuring the state machine works exactly the same for all strategy configs. If this is implemented, the queueAction still needs to be called if isFixedLengthApproval is true or if it's an optimistic strategy (with approvalPeriod = 0 and minApprovalPct=0 since the state will automatically be at Approved state).

0xrajath commented 1 year ago

Related to https://github.com/spearbit-audits/review-llama2/issues/21