llamaxyz / llama

Llama is an onchain governance and access control framework for smart contracts.
https://llama.xyz
MIT License
47 stars 5 forks source link

feat: Token rescue functions in the core and token rescue script for executor #459

Closed 0xrajath closed 1 year ago

0xrajath commented 1 year ago

https://github.com/spearbit-audits/review-llama2/pull/1#discussion_r1275133351

TO BE DISCUSSED: Whether we need rescue functions for ERC20s, ERC721s and ERC1155s in the Core and a rescue script for the executor to delegatecall.

0xrajath commented 1 year ago

Related to https://github.com/spearbit-audits/review-llama2/issues/13

AustinGreen commented 1 year ago

We decided against taking action due to the fact that a rescueToken function LlamaCore would mean that the core could make a call to an untrusted external contract.