search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

[Fixed issue #103] UI improvement in toolbar #104

Closed S-kus closed 2 years ago

S-kus commented 2 years ago

Fixes: #103

1:

Corrected the arrow functionality. As shown:

sol1

2:

Removed fixed height of toolbar to make it responsive, Now it's working like other activities for small screens as well. As shown: sol2

llaske commented 2 years ago

Thanks for this fix. That's fine for the fix of https://github.com/llaske/sugarizer/issues/748. Regarding toolbar, the size must stay fixed on Sugar. Sugarizer activities should not be fully responsive see here for more about that.

S-kus commented 2 years ago

Thanks, @llaske I have done the required correction with toolbar height. You can review it again.

As arrow functionality changes are correct, Can I raise the pull request in the Sugarizer repository as well, with required changes?

llaske commented 2 years ago

@S-kus Fine. Thanks.