search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Improvement in Exercise Cards #108

Closed gitkaarma closed 2 years ago

gitkaarma commented 2 years ago

To open an activity we have to click on the play button itself. Intuitively, the exercise should open on clicking anywhere on the card.

https://user-images.githubusercontent.com/96700361/158371350-a0a38372-6885-45db-8396-85eae9f5870d.mp4

Also adding hover effect on particular card would help the user.

https://user-images.githubusercontent.com/96700361/158371369-673ab9eb-b56a-42b8-8a22-70a94c76f8c3.mp4

ashish0910 commented 2 years ago

@gitkaarma would be great to have open by clicking on anywhere on the card but don't think we should have a hover effect What do you think @llaske?

llaske commented 2 years ago

Hmmm. The problem is that for the future evolution of this activity, it's planned to "to always display shared buttons on exercises". So how to be compatible with this new behavior?

gitkaarma commented 2 years ago

@llaske I understand your point. Can we just add the hover effect?

llaske commented 2 years ago

@gitkaarma sure you could add a light hover effect like in the Vote activity. Note that Sugarizer is often use on touch screen where the hover effect doesn't exist. It's why we can't depend on it.

gitkaarma commented 2 years ago

@llaske, I agree that hover effect is useful only for desktop users. For now I have added hover effect similar to vote activity and removed 'onClick' on Exercise card.