search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

feature: FreeTextInputPlayer submit button validation added #111

Closed bdbose closed 1 year ago

bdbose commented 2 years ago

The submit button on FreeTextInputPlayer Exercise page one can submit without even attempting any question. So I added a check(button disable feature) if one user have attempted any question or not before submitting.

Shreyas-SAS commented 2 years ago

@bdbose if I am correct, you removed the possibility of returning the test empty.

what if I do not know any of the answer and want to end the test rather than wasting my time attempting it. It will always restrict me from making a blank submission. In this case will it not be a problem? since the only way to close it is force close of the whole activity and not submission for a zero score.

It may mark the person absent rather than giving him a zero right? These two may create a very different output when say taking supplementary exams for those who were absent and not those who got 0.

bdbose commented 2 years ago

Yes got your point actually I saw this validation on submit button on the Matching Pair exercises so I thought to add them to all . Then also we should remove it from Matching Pair exercise too ?

Shreyas-SAS commented 2 years ago

Yes got your point actually I saw this validation on submit button on the Matching Pair exercises so I thought to add them to all . Then also we should remove it from Matching Pair exercise too ?

I did not get it clearly which exercise you were trying to refer to but I think that if it is outside exerciser then it would not matter much. Basically exercizer can be seen like a test or quiz activity so the concept to submit blank answer script seems valid. If the other activity does not require a grading then we can maybe leave it as it is.

Still I do not hold the authority to decide what is beneficial for repo after considering just my point of view. I would rather like @llaske to have a look at the suggestion once.

llaske commented 2 years ago

I'm agree with @Shreyas-SAS It's valid to submit an empty answer.

llaske commented 1 year ago

Close due to lack of activity.