search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Improvement in Graph #118

Closed gitkaarma closed 2 years ago

gitkaarma commented 2 years ago

If someone takes more than 10 minutes to finish an exercise, his time graph just shoots to the top.

image

It would be difficult to compare relative performance in such scenarios.

Also there is no marking(what they represent) on x and y axes. Should we also add that?

llaske commented 2 years ago

You're right, it will be better to adapt the scale to the number of minutes. Why not adding mn and % on the vertical axis.

gitkaarma commented 2 years ago

What can be the basis of our scaling @llaske ? Can we set the maximum limit to something like (maximum time taken by a student + x) minutes. x maybe 10, 20, 50 minutes.

llaske commented 2 years ago

If we change the current graph, the idea is to have a "smart" graph that adapt to the maximum. The default maximum will be 10 minutes like today and it will adapt to the maximum if it's higher.

gitkaarma commented 2 years ago

https://user-images.githubusercontent.com/96700361/161396376-199adf66-fdf5-41a8-b4d1-838ecf85d7d5.mp4

@llaske Can you please review the changes?

I took more than 10 minutes to complete the test, so the minutes graph adapted accordingly. If the user takes less than 10 minutes, the max y-axis limit will be 10 minutes.

Also the x and y axes are now labelled.