llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Added labelling to axes, made graph dynamic #119

Closed gitkaarma closed 2 years ago

gitkaarma commented 2 years ago

fixes #118

llaske commented 2 years ago

Hmmm. Finally the labelling doesn't help. It's obvious. It will be better to add unit behind the value : 1mn, 2mn, 3mn, ... 10%, 20%, 30%, ... The dynamic graph is nice.

gitkaarma commented 2 years ago

image

@llaske, I think this is it. Should I remove the y-axis and x-axis labels (minutes on y-axis and users on x-axis)?

llaske commented 2 years ago

@gitkaarma yes, it doesn't help. Because there is the user name it's obvious that the graph is for the user. Because you've added unit, it's obvious that it's minute/percentage.

gitkaarma commented 2 years ago

@llaske Done, PTAL!

llaske commented 2 years ago

That's nice but there is an issue when switch from result to time, the bar is very large.

Peek 06-04-2022 22-04

gitkaarma commented 2 years ago

@llaske, fixed.

llaske commented 2 years ago

Good job. Thanks.