search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Adjust the width and height of the images of the exercise #134

Closed nikkuAg closed 2 years ago

nikkuAg commented 2 years ago
1 2 3 4

Issue: #120

nikkuAg commented 2 years ago

I have removed the whitespace from the images and also the images are completely visible. But I feel that it is not pleasing to look as the images are getting stretched and the aspect ratio of the images is getting distorted, so I think we should go with the solution in the PR #121

llaske commented 2 years ago

Hmmm I guess my explanation here was not clear. Sorry for that. My idea is not to change the fix https://github.com/llaske/ExerciserReact/pull/121. My idea is to adapt images in src/media/defaultExerciseThumbnail to adapt to the fix so it look better.

nikkuAg commented 2 years ago

@llaske Sorry but not able to understand what basically you mean by adapt, should I crop the image so that it fits perfectly and also the important stuff is visible, or you are suggesting something else

llaske commented 2 years ago

Yes that's exactly the idea

nikkuAg commented 2 years ago

Ok but there also some images will loose the data if we crop them according to fit it completely

llaske commented 2 years ago

It doesn't mind. It's just illustrations.

nikkuAg commented 2 years ago

But cropping of images is done in the default mode already

Screenshot 2022-06-08 at 5 26 45 PM

Screenshot 2022-06-08 at 5 22 57 PM

llaske commented 2 years ago

Yes but with the new fix there is no more cropping.

nikkuAg commented 2 years ago

I am not able to understand the fix you are suggesting in the changes in the PR #121

llaske commented 2 years ago

Okay, let's restart from the beginning: The issue https://github.com/llaske/ExerciserReact/issues/120 suggest that it will be better to center images used for Exercise illustration. The PR https://github.com/llaske/ExerciserReact/pull/121 fix the issue but the side effect is that few images in samples exercises don't fit the new size (white margin around). What I'm expect is to resize these images (in src/media/defaultExerciseThumbnail) to adapt to the fix so it look better.