search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

maching player able to match from both sides. #164

Closed UtkarshSiddhpura closed 1 year ago

UtkarshSiddhpura commented 1 year ago

@llaske Fixes :

https://github.com/llaske/sugarizer/issues/1337

enjoy the template by matching from both sides now!

I tested it with every possible break it works perfectly.

NischayGoyal1 commented 1 year ago

@UtkarshSiddhpura this issue is created by @ABHINAV-JHA-27 and before raising a direct PR you should ask him whether he is still working on it or not, this should be the right practice👍.

UtkarshSiddhpura commented 1 year ago

@UtkarshSiddhpura this issue is created by @ABHINAV-JHA-27 and before raising a direct PR you should ask him whether he is still working on it or not, this should be the right practice👍.

Sure, i thought no one is working on it as there is no further activity on the issue.

ABHINAV-JHA-27 commented 1 year ago

I think it would have been better if you would have asked before opening a PR but its alright.

UtkarshSiddhpura commented 1 year ago

My perspective is opening an issue should be open to everyone to fix, allowing competition of ideas. If someone has a better solution, they can also make a pull request so that the best possible solution can be chosen based on on its quality rather waiting for a reply. I think that's why there is no "assigned issues" here. (see contributing.md)

Also making a good Issue is as valuable as creating an optimal solution & credits for you for doing that.

llaske commented 1 year ago

It's very cool to have this feature. Thanks @UtkarshSiddhpura