search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Fixes crashes in development mode #2

Closed NikhilM98 closed 5 years ago

NikhilM98 commented 5 years ago

Closes issue #6. The color value was not handled properly which was causing the react app to throw an error that cannot read property of undefined. According to the original developer, this app is not expected to function properly in development mode due to dependence on Sugarizer and Sugarizer Neighborhood data but I still think that result screen is a crucial functionality of the app and it should not break at the result screen even at the development mode.

NikhilM98 commented 5 years ago

P.S. @llaske I'm participating in GSoC'19 and I want to discuss my ideas regarding Sugarizer, Exerciser, and other activities.

llaske commented 5 years ago

Not a bad idea to solve this issue to allow work in dev mode.

Could you reopen the issue on this repo to reference it here?

Plus, your PR include code update not related to this fix (see my comments). Could you clean it?

NikhilM98 commented 5 years ago

@llaske I've made the changes you asked for. There are some components which are imported in the code but are not being used. It would be inefficient to import such components. I've also made some other suggestions here. Can you please review them.

llaske commented 5 years ago

Okay thanks. Will review your suggestions.