Fixes #21: User can now add images in cloze form

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018

Apache License 2.0

15 stars 49 forks source link

Fixes #21: User can now add images in cloze form #22

Closed AvinashAgarwal14 closed 5 years ago

AvinashAgarwal14 commented 5 years ago

Fixes #21

Before: Cloze Form: before_cloze_form Cloze Player: before_cloze_player

After: Cloze Form: cloze_form Cloze Player: cloze_player

llaske commented 5 years ago

I've got an issue when I'm clicking on the Insert image button:

AvinashAgarwal14 commented 5 years ago

@llaske As there are some changes in lib folder as well, you will need to copy the lib folder into node modules again. Also as it involves using journal chooser and pre-uploading images into the journal the fronted code won't work on its own. Please follow the steps below:

1. Copy lib into node modules.
2. npm install
3. npm run build
4. copy build folder into sugarizer activity
5. Run Exerciser from within sugarizer

AvinashAgarwal14 commented 5 years ago

@llaske Could you please review it and let me know if there are any changes that I should make ?

llaske commented 5 years ago

Could you fix conflict with latest master branch?

AvinashAgarwal14 commented 5 years ago

@llaske I have fixed the merge conflicts with the latest master branch. Please check it once.

llaske commented 5 years ago

It works now. Very good work. A good start for this feature.

AvinashAgarwal14 commented 5 years ago

@llaske Thank you. Is there anything else that I should change with respect to this PR?

llaske commented 5 years ago

@AvinashAgarwal14 No that's fine. Thanks for your work. It's a good proof of concept. BTW I will not merge it now, we must think more about UI to integrate images in the whole activity before going further.

AvinashAgarwal14 commented 5 years ago

@llaske Thanks. This PR enables users to add images in Cloze Question. Multimedia support in answers as well is still to be integrated. Also, currently the addition of image in question's UI is in consistence with learning apps website's UI. Let me know if you have something in mind with respect to its UI.