search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Detailed response of cloze form added #24

Closed AvinashAgarwal14 closed 5 years ago

AvinashAgarwal14 commented 5 years ago

Fixes: #23 After the PR: result

llaske commented 5 years ago

Nice. Do you test it with multiple users?

AvinashAgarwal14 commented 5 years ago

@llaske The current patch of code works only for displaying the results of a single user. Although the same idea can be extended to make it work for multiple users. As the idea for displaying the detailed results of multiple users is listed for this year's GSoC, I implemented it for a single user only. Should I go ahead and extend it for multiple users also?

llaske commented 5 years ago

@AvinashAgarwal14 No that's fine for the moment.

AvinashAgarwal14 commented 5 years ago

@llaske Okay. Should I make any other changes with respect to this PR?

AvinashAgarwal14 commented 5 years ago

Could you test with multiple users?

@llaske I have added support for multiple users as well, should I push the code?

llaske commented 5 years ago

@AvinashAgarwal14 Yes, please so I could review it.

AvinashAgarwal14 commented 5 years ago

@llaske I have updated the PR. Please review it and let me know what change you expect. Thanks :)

llaske commented 5 years ago

Don't work on my side, I've got 2 errors in the console.

image

Plus, will be nice if the detail could be displayed just by clicking on the chart.

AvinashAgarwal14 commented 5 years ago

Don't work on my side, I've got 2 errors in the console.

image

Plus, will be nice if the detail could be displayed just by clicking on the chart.

@llaske I have fixed this error in the last commit(2ff5f17) itself, please try rebuilding exerciser and docker service once. Okay, I will get to work on displaying the result page by on clicking the chart right away.

AvinashAgarwal14 commented 5 years ago

@llaske I have made the changes as asked by you. Please review it. Thanks :)

AvinashAgarwal14 commented 5 years ago

@llaske Could you please review the changes?