cloze-text-ui-improved - Githubissues

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018

Apache License 2.0

15 stars 49 forks source link

cloze-text-ui-improved #3

Closed AvinashAgarwal14 closed 5 years ago

AvinashAgarwal14 commented 5 years ago

Before : screenshot from 2019-03-06 17-08-01

After: screenshot from 2019-03-06 17-08-32

AvinashAgarwal14 commented 5 years ago

P.S. @llaske I'm participating in GSoC'19 and I want to discuss my ideas regarding improving Exerciser.

llaske commented 5 years ago

It's not really an improvement. Our inspiration for this activity come form LearningApps Cloze text in LearningApps are represented by white square like we've done. BTW an improvement could be to expand size between lines to avoid overlap of white squares.

Plus, avoid to include package-lock.json into your PR.

AvinashAgarwal14 commented 5 years ago

Okay, I did not know that. I have reverted back the changes and introduced some spaces in between those white square.

llaske commented 5 years ago

Nice. Thanks.