Free Text Input Template Added

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018

Apache License 2.0

15 stars 49 forks source link

Free Text Input Template Added #51

Closed AvinashAgarwal14 closed 5 years ago

AvinashAgarwal14 commented 5 years ago

Fixes: #50 Freetext_Demo

AvinashAgarwal14 commented 5 years ago

@llaske Could you please review this PR?

llaske commented 5 years ago

Very nice. UI could probably be improved but that's really the idea.

AvinashAgarwal14 commented 5 years ago

@llaske I will make some fine UI changes. If you want some specific changes please let me know.

llaske commented 5 years ago

Few remarks:

On template selection screen the image for the new template should be changed, it's the same than fill in the blank template.
Because the template selection screen is now scrollable, the background color is not applied on the scrolled part (background is white).
The answer box overlap the box limit when text is too short (see screen capture)

AvinashAgarwal14 commented 5 years ago

@llaske Thank you for reviewing the PR. I was not able to find a similar background image, that why I used blank's image. Is there any specific website from where I can find a similar background image. Regarding the other two issues, I will work on them and update the PR shortly.

llaske commented 5 years ago

I've replaced old images and added a new one (freetext_input_image.svg) in https://github.com/llaske/ExerciserReact/commit/c604b360fab05e0ad7f6182ab5a9b46638e3f636

AvinashAgarwal14 commented 5 years ago

@llaske Thank you, I have made the above changes, Please review.