search

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018
Apache License 2.0
15 stars 49 forks source link

Exercise thumbnail feature added #62

Closed AvinashAgarwal14 closed 5 years ago

AvinashAgarwal14 commented 5 years ago

Fixes: #61

AvinashAgarwal14 commented 5 years ago

@llaske Adding thumbnail to Exercises kind of makes it difficult to read the text, which is definitely not suitable for kids. Please suggest some UI changes in order to overcome this issue.

llaske commented 5 years ago

I've got an error message when I click on Add thumbnail button

image

Plus, could you post a short video to understand how it works.

AvinashAgarwal14 commented 5 years ago

For it to work, the followings steps need to be redone.

1. npm install.
2. copy lib folder into node modules.
llaske commented 5 years ago

Seems that the thumbnail is not updated. When it's changed, the new image is not displayed on the home for theExercise.

Plus, image proportions are altered on the detailed view (here's an image exported from Moon activity).

image