Matching pair template - Githubissues

llaske / ExerciserReact

React code of Exerciser Activity. GSoC 2018

Apache License 2.0

15 stars 49 forks source link

Closed AvinashAgarwal14 closed 5 years ago

llaske commented 5 years ago

Few remarks:

Clicking on "Test Exerciser" button don't save the last item. To reproduce: 1) create on pair, 2) click next, 3) create another pair, 4) click test
Items with Text use Italic style during run mode
A JSplumb error occur sometimes when trying to link items (see capture below)

llaske commented 5 years ago

Nice. Three more remarks:

With speech to text the user should be able to click anywhere to launch the sound (not only on the icon)
There is an error when trying to update the exercise after finishing it
Not directly related to this PR but in MCQ the test exercise button don't update the exercise

llaske commented 5 years ago

Everything is solved but there is an error when clicking on detailed result button at the end of the exercise.

llaske commented 5 years ago

I'm merging it but we're agree that a new PR should solve the proposal of @thingthing to do a component to avoid JSX repetition.